Allow clients that lack absl to built and use the library #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved Int128 definition to a separate header Added few extra methods to ColumnDecimal that do not rely on Int128 Ensured that client programs can be built without absl headers present.
Enmk
force-pushed
the
fix_no_absl_int128_builds
branch
from
b6babe9 to
e2e0ef5
Compare
traceon
reviewed
Jun 5, 2021
Comment on lines
+9
to
+13
| namespace absl | ||
| { | ||
| class int128; | ||
| } | ||
|
|
There was a problem hiding this comment.
Isn't it better to move all Int128 specific code and support into clickhouse/types/int128.h so that when user doesn't include that header he can't even refer to any type related/implemented via Int128?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Int128 definition to a separate header
Added few extra methods to ColumnDecimal that do not rely on Int128
Ensured that client programs can be built without absl headers present.
closes: #86